[Webkit-unassigned] [Bug 144762] Fix internal build configuration issues

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144762

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252631|review?                     |review-
              Flags|                            |

--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 252631
  --> https://bugs.webkit.org/attachment.cgi?id=252631
Cleans up xcconfig files in DumpRenderTree

View in context: https://bugs.webkit.org/attachment.cgi?id=252631&action=review

> Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:36
> +MACOSX_DEPLOYMENT_TARGET[sdk=iphone*] = 10.9;

We should be able to drop this for iOS. I don't see it in WebCore for iOS and it doesn't really make sense to have this on iOS.

> Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:48
> -SDKROOT = $(SDKROOT_$(PLATFORM_NAME));
> -SDKROOT_iphoneos = $(SDKROOT);
> -SDKROOT_iphonesimulator = $(SDKROOT);
> -SDKROOT_macosx = $(SDKROOT_macosx_$(USE_INTERNAL_SDK));
> +SDKROOT[sdk=macosx*] = $(SDKROOT_macosx_$(USE_INTERNAL_SDK));
>  SDKROOT_macosx_ = macosx;
>  SDKROOT_macosx_YES = macosx.internal;

I don't know why this doesn't work (mac builders failing). But the same change was made to WebCore's DebugRelease.xcconfig ended up with this:

    SDKROOT[sdk=iphone*] = $(SDKROOT);
    SDKROOT = $(SDKROOT_$(PLATFORM_NAME)_$(USE_INTERNAL_SDK));
    SDKROOT_macosx_ = macosx;
    SDKROOT_macosx_YES = macosx.internal;

Should work here too then!

> Tools/DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:29
> -OTHER_LDFLAGS_macosx = -framework Carbon -framework Cocoa -framework OpenGL -framework IOKit;
> +OTHER_LDFLAGS = $(inherited) $(MAYBE_OTHER_LDFLAGS);
> +MAYBE_OTHER_LDFLAGS[sdk=macosx*] = -framework Carbon -framework Cocoa -framework OpenGL -framework IOKit;

I think you can simplify this to just:

    OTHER_LDFLAGS[sdk=macosx*] = $(inherited) -framework Carbon -framework Cocoa -framework OpenGL -framework IOKit;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150507/e5a132ab/attachment.html>