<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix internal build configuration issues"
href="https://bugs.webkit.org/show_bug.cgi?id=144762">bug 144762</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #252631 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix internal build configuration issues"
href="https://bugs.webkit.org/show_bug.cgi?id=144762#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix internal build configuration issues"
href="https://bugs.webkit.org/show_bug.cgi?id=144762">bug 144762</a>
from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252631&action=diff" name="attach_252631" title="Cleans up xcconfig files in DumpRenderTree">attachment 252631</a> <a href="attachment.cgi?id=252631&action=edit" title="Cleans up xcconfig files in DumpRenderTree">[details]</a></span>
Cleans up xcconfig files in DumpRenderTree
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252631&action=review">https://bugs.webkit.org/attachment.cgi?id=252631&action=review</a>
<span class="quote">> Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:36
> +MACOSX_DEPLOYMENT_TARGET[sdk=iphone*] = 10.9;</span >
We should be able to drop this for iOS. I don't see it in WebCore for iOS and it doesn't really make sense to have this on iOS.
<span class="quote">> Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:48
> -SDKROOT = $(SDKROOT_$(PLATFORM_NAME));
> -SDKROOT_iphoneos = $(SDKROOT);
> -SDKROOT_iphonesimulator = $(SDKROOT);
> -SDKROOT_macosx = $(SDKROOT_macosx_$(USE_INTERNAL_SDK));
> +SDKROOT[sdk=macosx*] = $(SDKROOT_macosx_$(USE_INTERNAL_SDK));
> SDKROOT_macosx_ = macosx;
> SDKROOT_macosx_YES = macosx.internal;</span >
I don't know why this doesn't work (mac builders failing). But the same change was made to WebCore's DebugRelease.xcconfig ended up with this:
SDKROOT[sdk=iphone*] = $(SDKROOT);
SDKROOT = $(SDKROOT_$(PLATFORM_NAME)_$(USE_INTERNAL_SDK));
SDKROOT_macosx_ = macosx;
SDKROOT_macosx_YES = macosx.internal;
Should work here too then!
<span class="quote">> Tools/DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:29
> -OTHER_LDFLAGS_macosx = -framework Carbon -framework Cocoa -framework OpenGL -framework IOKit;
> +OTHER_LDFLAGS = $(inherited) $(MAYBE_OTHER_LDFLAGS);
> +MAYBE_OTHER_LDFLAGS[sdk=macosx*] = -framework Carbon -framework Cocoa -framework OpenGL -framework IOKit;</span >
I think you can simplify this to just:
OTHER_LDFLAGS[sdk=macosx*] = $(inherited) -framework Carbon -framework Cocoa -framework OpenGL -framework IOKit;</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>