[Webkit-unassigned] [Bug 141692] Web Inspector: Styles sidebar editing with incomplete property looks poor in UI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141692

--- Comment #31 from tobi+bugzilla at basecode.de ---
> "Align" may not be the best word here. Maybe "Enable" would be better?

Done.

> To prevent duplication we should be able to just include a file to get this. Even if it means moving the original out of CodeMirrorAdditions.js and into a new file like CodeMirrorModeAdditions.js and including that from here.

Good point. It turned out that requiring WebInspector.js was sufficient.

> var indentString = "    ";

Done.

> I wonder if /\s+/g could be more efficient.

Done. Although multiple spaces should't exist at that point.

> var cssPropertiesMap = new Map;

Done. Didn't know that. Great!

> Here is another case, you can combine an if:

Done.

> if (!token)

Done.

> So that once a token is matched once, it doesn't need to drop to all of the other cases that do not matter.

Done.

> I'd prefer the isComment up at the top, as it is a cheap check that might prevent unnecessary regex work.

Done.

> border: solid blue -webkit-calc(1px);

Good catch! I fixed it and added a test case accordingly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150505/d7dca9f8/attachment.html>