<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Styles sidebar editing with incomplete property looks poor in UI"
href="https://bugs.webkit.org/show_bug.cgi?id=141692#c31">Comment # 31</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Styles sidebar editing with incomplete property looks poor in UI"
href="https://bugs.webkit.org/show_bug.cgi?id=141692">bug 141692</a>
from <span class="vcard"><a class="email" href="mailto:tobi+bugzilla@basecode.de" title="tobi+bugzilla@basecode.de">tobi+bugzilla@basecode.de</a>
</span></b>
<pre><span class="quote">> "Align" may not be the best word here. Maybe "Enable" would be better?</span >
Done.
<span class="quote">> To prevent duplication we should be able to just include a file to get this. Even if it means moving the original out of CodeMirrorAdditions.js and into a new file like CodeMirrorModeAdditions.js and including that from here.</span >
Good point. It turned out that requiring WebInspector.js was sufficient.
<span class="quote">> var indentString = " ";</span >
Done.
<span class="quote">> I wonder if /\s+/g could be more efficient.</span >
Done. Although multiple spaces should't exist at that point.
<span class="quote">> var cssPropertiesMap = new Map;</span >
Done. Didn't know that. Great!
<span class="quote">> Here is another case, you can combine an if:</span >
Done.
<span class="quote">> if (!token)</span >
Done.
<span class="quote">> So that once a token is matched once, it doesn't need to drop to all of the other cases that do not matter.</span >
Done.
<span class="quote">> I'd prefer the isComment up at the top, as it is a cheap check that might prevent unnecessary regex work.</span >
Done.
<span class="quote">> border: solid blue -webkit-calc(1px);</span >
Good catch! I fixed it and added a test case accordingly.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>