[Webkit-unassigned] [Bug 144542] [SOUP] Network Cache: IOChannel operations are not sent to the right thread

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144542

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 252264 [details]
> Patch

Thanks for the review.

> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252264&action=review
> 
> Too bad all this code is boilerplate and repeated three times. Seems like
> instead you could have a helper function and that takes a single lambda to
> abstract away which of the three IOChannel functions is called.

Will do it.

> > Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:162
> > +    GMainLoopSource::scheduleAndDeleteOnDestroy("[WebKit] IOChannel::read", std::function<void()>([channel, offset, size, completionHandler] {
> > +        channel->read(offset, size, completionHandler);
> > +    }), G_PRIORITY_DEFAULT, nullptr, g_main_context_default());
> 
> Why is that typecast to std::function needed? Should just work without it.

There were some problemas with some compilers, see bug #131006, for example. I thought there were issues with GCC, but it seems it's MSVC, so it doesn't affect us here, I will remove the casts.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150505/031e98bf/attachment.html>