<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Network Cache: IOChannel operations are not sent to the right thread"
href="https://bugs.webkit.org/show_bug.cgi?id=144542#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Network Cache: IOChannel operations are not sent to the right thread"
href="https://bugs.webkit.org/show_bug.cgi?id=144542">bug 144542</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144542#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=252264&action=diff" name="attach_252264" title="Patch">attachment 252264</a> <a href="attachment.cgi?id=252264&action=edit" title="Patch">[details]</a></span>
> Patch</span >
Thanks for the review.
<span class="quote">> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=252264&action=review">https://bugs.webkit.org/attachment.cgi?id=252264&action=review</a>
>
> Too bad all this code is boilerplate and repeated three times. Seems like
> instead you could have a helper function and that takes a single lambda to
> abstract away which of the three IOChannel functions is called.</span >
Will do it.
<span class="quote">> > Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:162
> > + GMainLoopSource::scheduleAndDeleteOnDestroy("[WebKit] IOChannel::read", std::function<void()>([channel, offset, size, completionHandler] {
> > + channel->read(offset, size, completionHandler);
> > + }), G_PRIORITY_DEFAULT, nullptr, g_main_context_default());
>
> Why is that typecast to std::function needed? Should just work without it.</span >
There were some problemas with some compilers, see <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - std::bind not compiling with Visual Studio"
href="show_bug.cgi?id=131006">bug #131006</a>, for example. I thought there were issues with GCC, but it seems it's MSVC, so it doesn't affect us here, I will remove the casts.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>