[Webkit-unassigned] [Bug 144561] [GTK] Re-enable Quartz backend on cmake build system

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144561

--- Comment #4 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 252296
  --> https://bugs.webkit.org/attachment.cgi?id=252296
Patch to re-enable Quartz backend

View in context: https://bugs.webkit.org/attachment.cgi?id=252296&action=review

Thanks for the patch. Is this patch for master? If so, I think it needs to be rebased. Also, as Csaba mentioned all patches need ChangeLogs.

> b/Source/cmake/OptionsGTK.cmake:181
> +if (ENABLE_QUARTZ_TARGET)
> +    add_definitions(-DWTF_PLATFORM_QUARTZ=1)
> +endif ()

We expose variables to the build using SET_AND_EXPOSE_TO_BUILD now.

> b/Source/cmake/FindGTK3.cmake:66
> +    if (NOT("${GTK3_QUARTZ_VERSION}" VERSION_EQUAL "${GTK3_VERSION}"))
> +        set(ENABLE_QUARTZ_TARGET OFF)
> +    endif ()

Here you should give an error, because we want the build to produce errors instead of silently disabling things now.

> b/Source/cmake/FindGTK3.cmake:73
> +if (NOT(ENABLE_X11_TARGET OR ENABLE_WAYLAND_TARGET OR ENABLE_QUARTZ_TARGET))
>      message(FATAL_ERROR "At least one of the following windowing targets must "
> -        "be enabled and also supported by the GTK+ dependency: X11, Wayland")
> +        "be enabled and also supported by the GTK+ dependency: X11, Wayland, "
> +        "Quartz")
>  endif ()

I don't think the help message should mention Quartz until the port is fully functional.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150504/2bb9c350/attachment-0001.html>