<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Re-enable Quartz backend on cmake build system"
href="https://bugs.webkit.org/show_bug.cgi?id=144561#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Re-enable Quartz backend on cmake build system"
href="https://bugs.webkit.org/show_bug.cgi?id=144561">bug 144561</a>
from <span class="vcard"><a class="email" href="mailto:mrobinson@webkit.org" title="Martin Robinson <mrobinson@webkit.org>"> <span class="fn">Martin Robinson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252296&action=diff" name="attach_252296" title="Patch to re-enable Quartz backend">attachment 252296</a> <a href="attachment.cgi?id=252296&action=edit" title="Patch to re-enable Quartz backend">[details]</a></span>
Patch to re-enable Quartz backend
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252296&action=review">https://bugs.webkit.org/attachment.cgi?id=252296&action=review</a>
Thanks for the patch. Is this patch for master? If so, I think it needs to be rebased. Also, as Csaba mentioned all patches need ChangeLogs.
<span class="quote">> b/Source/cmake/OptionsGTK.cmake:181
> +if (ENABLE_QUARTZ_TARGET)
> + add_definitions(-DWTF_PLATFORM_QUARTZ=1)
> +endif ()</span >
We expose variables to the build using SET_AND_EXPOSE_TO_BUILD now.
<span class="quote">> b/Source/cmake/FindGTK3.cmake:66
> + if (NOT("${GTK3_QUARTZ_VERSION}" VERSION_EQUAL "${GTK3_VERSION}"))
> + set(ENABLE_QUARTZ_TARGET OFF)
> + endif ()</span >
Here you should give an error, because we want the build to produce errors instead of silently disabling things now.
<span class="quote">> b/Source/cmake/FindGTK3.cmake:73
> +if (NOT(ENABLE_X11_TARGET OR ENABLE_WAYLAND_TARGET OR ENABLE_QUARTZ_TARGET))
> message(FATAL_ERROR "At least one of the following windowing targets must "
> - "be enabled and also supported by the GTK+ dependency: X11, Wayland")
> + "be enabled and also supported by the GTK+ dependency: X11, Wayland, "
> + "Quartz")
> endif ()</span >
I don't think the help message should mention Quartz until the port is fully functional.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>