[Webkit-unassigned] [Bug 144560] [GTK] Fix combinations of PLATFORM(GTK) and OS(DARWIN)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 4 03:30:03 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=144560

Csaba Osztrogonác <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252295|review?                     |review-
              Flags|                            |

--- Comment #3 from Csaba Osztrogonác <ossy at webkit.org> ---
Comment on attachment 252295
  --> https://bugs.webkit.org/attachment.cgi?id=252295
Patch for OS(DARWIN) and PLATFORM(GTK)

View in context: https://bugs.webkit.org/attachment.cgi?id=252295&action=review

Please add changelog with prepare-changelog, see
https://www.webkit.org/coding/contributing.html for details.

Additionally we will need review from WK2 owners too.

> b/Source/WebCore/platform/graphics/opentype/OpenTypeMathData.cpp:43
> -#if OS(DARWIN)
> +#if OS(DARWIN) && !PLATFORM(GTK)

Why not simply "#if PLATFORM(COCOA)" ?
(Not only here, everywhere.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150504/bb6073dd/attachment.html>


More information about the webkit-unassigned mailing list