<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ossy@webkit.org" title="Csaba Osztrogonác <ossy@webkit.org>"> <span class="fn">Csaba Osztrogonác</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Fix combinations of PLATFORM(GTK) and OS(DARWIN)"
href="https://bugs.webkit.org/show_bug.cgi?id=144560">bug 144560</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #252295 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Fix combinations of PLATFORM(GTK) and OS(DARWIN)"
href="https://bugs.webkit.org/show_bug.cgi?id=144560#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Fix combinations of PLATFORM(GTK) and OS(DARWIN)"
href="https://bugs.webkit.org/show_bug.cgi?id=144560">bug 144560</a>
from <span class="vcard"><a class="email" href="mailto:ossy@webkit.org" title="Csaba Osztrogonác <ossy@webkit.org>"> <span class="fn">Csaba Osztrogonác</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252295&action=diff" name="attach_252295" title="Patch for OS(DARWIN) and PLATFORM(GTK)">attachment 252295</a> <a href="attachment.cgi?id=252295&action=edit" title="Patch for OS(DARWIN) and PLATFORM(GTK)">[details]</a></span>
Patch for OS(DARWIN) and PLATFORM(GTK)
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252295&action=review">https://bugs.webkit.org/attachment.cgi?id=252295&action=review</a>
Please add changelog with prepare-changelog, see
<a href="https://www.webkit.org/coding/contributing.html">https://www.webkit.org/coding/contributing.html</a> for details.
Additionally we will need review from WK2 owners too.
<span class="quote">> b/Source/WebCore/platform/graphics/opentype/OpenTypeMathData.cpp:43
> -#if OS(DARWIN)
> +#if OS(DARWIN) && !PLATFORM(GTK)</span >
Why not simply "#if PLATFORM(COCOA)" ?
(Not only here, everywhere.)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>