[Webkit-unassigned] [Bug 143052] Separate entry decoding from validation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 25 13:35:47 PDT 2015


--- Comment #6 from Antti Koivisto <koivisto at iki.fi> ---
(In reply to comment #4)
> Comment on attachment 249413 [details]
> nit: I still prefer make_unique() and auto for the variable type.

Me too, unfortunately make_unique does not work with private constructor and I think that is a preferable feature here.

> We never return false so why bother returning a boolean? This way we don't
> need error handling as the call site.

Good point.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150325/42089f07/attachment-0002.html>

More information about the webkit-unassigned mailing list