[Webkit-unassigned] [Bug 142836] Add events related to force click gesture

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142836

Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249252|review?                     |review+
              Flags|                            |

--- Comment #42 from Dean Jackson <dino at apple.com> ---
Comment on attachment 249252
  --> https://bugs.webkit.org/attachment.cgi?id=249252
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249252&action=review

Are we going to update testRunner to be able to generate these mouse events?

> Source/WebCore/ChangeLog:15
> +        webkitmouseforcewillbegin -> Event is sent just before mousedown to indicate that 
> +        force can be perceived if the user presses any harder. The author should prevent 
> +        default on this event to both prevent the user agent’s default force click 
> +        features and to receive the other 5 events.

It's interesting that you have to prevent default here in order to get the other events. I'm not sure we have anything else like that.

> Source/WebCore/ChangeLog:45
> +        Add new files for WebKitMouseForceChangedEvent to build systems.
> +        * DerivedSources.cpp:
> +        * DerivedSources.make:
> +        * WebCore.vcxproj/WebCore.vcxproj:
> +        * WebCore.vcxproj/WebCore.vcxproj.filters:
> +        * WebCore.xcodeproj/project.pbxproj:
> +        * WebCore.xcodeproj/project.pbxproj:

No changes to the cmake files?

> Source/WebCore/dom/Element.h:475
> +    WEBCORE_EXPORT void dispatchMouseForceDown();
> +    WEBCORE_EXPORT void dispatchMouseForceUp();
> +    WEBCORE_EXPORT void dispatchMouseForceClick();

Why don't you need a PlatformMouseEvent here (at least for WillBegin, Down and Cancelled)? Don't we need a target?

> Source/WebCore/dom/EventNames.in:32
>  WebKitAnimationEvent
> +WebKitMouseForceChangedEvent
>  WebKitTransitionEvent

Why is there only one addition here? I expected a WebKitMouseForceDownEvent, WillBegin and Cancelled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150323/67a6ab40/attachment-0002.html>