[Webkit-unassigned] [Bug 142836] Add events related to force click gesture

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142836

--- Comment #43 from Beth Dakin <bdakin at apple.com> ---
(In reply to comment #42)
> Comment on attachment 249252 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249252&action=review
> 
> Are we going to update testRunner to be able to generate these mouse events?
> 

Yes! I am planning to hook this up very soon. Will file a follow-up bug.

> > Source/WebCore/ChangeLog:15
> > +        webkitmouseforcewillbegin -> Event is sent just before mousedown to indicate that 
> > +        force can be perceived if the user presses any harder. The author should prevent 
> > +        default on this event to both prevent the user agent’s default force click 
> > +        features and to receive the other 5 events.
> 
> It's interesting that you have to prevent default here in order to get the
> other events. I'm not sure we have anything else like that.
> 

It is a bit weird, but I fear spamming way too many events on web content that simply doesn't care otherwise. I think it's the right trade-off. I'm sure this will get further discussion.

> > Source/WebCore/ChangeLog:45
> > +        Add new files for WebKitMouseForceChangedEvent to build systems.
> > +        * DerivedSources.cpp:
> > +        * DerivedSources.make:
> > +        * WebCore.vcxproj/WebCore.vcxproj:
> > +        * WebCore.vcxproj/WebCore.vcxproj.filters:
> > +        * WebCore.xcodeproj/project.pbxproj:
> > +        * WebCore.xcodeproj/project.pbxproj:
> 
> No changes to the cmake files?
> 

I did edit CMakeLists.txt, but it looks like somehow that missed the Changelog. My build is still failing on Win though, so I'm missing something…

> > Source/WebCore/dom/Element.h:475
> > +    WEBCORE_EXPORT void dispatchMouseForceDown();
> > +    WEBCORE_EXPORT void dispatchMouseForceUp();
> > +    WEBCORE_EXPORT void dispatchMouseForceClick();
> 
> Why don't you need a PlatformMouseEvent here (at least for WillBegin, Down
> and Cancelled)? Don't we need a target?
> 
> > Source/WebCore/dom/EventNames.in:32
> >  WebKitAnimationEvent
> > +WebKitMouseForceChangedEvent
> >  WebKitTransitionEvent
> 
> Why is there only one addition here? I expected a WebKitMouseForceDownEvent,
> WillBegin and Cancelled.

Hmmm, still thinking this over…

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150323/6a631f2e/attachment-0002.html>