[Webkit-unassigned] [Bug 142810] Prune least valuable cache entries first

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142810

--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 248913
  --> https://bugs.webkit.org/attachment.cgi?id=248913
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248913&action=review

>> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:312
>> +                auto entry = decodeEntry(fileData, channel->fileDescriptor(), read.key);
> 
> Is there something that guarantees that the file descriptor is still open at this point? Just extending the lifetime of the IOChannel alone doesn’t seem to guarantee that.

It should, slightly indirectly. File closes when the underlying dispatch_io closes and IOChannel refs it:

m_dispatchIO = adoptDispatch(dispatch_io_create(DISPATCH_IO_RANDOM, fd, dispatch_get_main_queue(), [fd](int) {
        close(fd);
 }));

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150318/1df56560/attachment-0002.html>