[Webkit-unassigned] [Bug 142810] Prune least valuable cache entries first

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142810

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #248913|review?                     |review+
              Flags|                            |

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 248913
  --> https://bugs.webkit.org/attachment.cgi?id=248913
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248913&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystemPosix.h:87
> +    auto times = fileTimes(path);

It’s a little bit irritating that this function calls fileSystemRepresentation on the path twice, allocating two separate C strings.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:312
> +                auto entry = decodeEntry(fileData, channel->fileDescriptor(), read.key);

Is there something that guarantees that the file descriptor is still open at this point? Just extending the lifetime of the IOChannel alone doesn’t seem to guarantee that.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:592
> +    if (age <= seconds::zero() || accessAge > age)
> +        return maximumProbability;

No check for accessAge < 0?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150318/40b0bf61/attachment-0002.html>