[Webkit-unassigned] [Bug 131162] [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131162

--- Comment #9 from Gyuyoung Kim <gyuyoung.kim at webkit.org> ---
Comment on attachment 247847
  --> https://bugs.webkit.org/attachment.cgi?id=247847
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247847&action=review

> Source/WebKit2/ChangeLog:13
> +        Propose a new callbacks which are view independent and detach EFL's DownloadMaager

Typo: DownloadMaager -> DownloadManager

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp:-44
> -class EWK2DownloadJobTest : public EWK2UnitTestBase {

Why should we remove this unit test ? I think we need to modify this unit test based on this change.

> Source/WebKit2/UIProcess/efl/DownloadManagerEfl.cpp:164
> +    RefPtr<EwkDownloadJob> ewkDownload = EwkDownloadJob::create(download);

I think EwkDownloadJob::create() is not necessary. We can make an instance with new EwkDownloadJob if we move its constructor from private to public.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150305/2455f4a8/attachment-0002.html>