[Webkit-unassigned] [Bug 131162] [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131162

--- Comment #8 from Ryuan Choi <ryuan.choi at navercorp.com> ---
(In reply to comment #7)
> Hello,
> 
> I have uploaded new patch with (almost) all comments included. To answer
> your questions:
> 
> > I am not sure.
> > Doesn't we have any use cases which need to distinguish which ewk_view(tab)
> > requests this download?
> 
> As far as I know, all modern browsers have general download manager common
> for all tabs/windows. When user starts to download a file, dialog bog
> appears and then download is conducted by an agent located next to address
> bar. When it is finished, agent's icon is blinking, not a tab.
> 
OK.

> > Bug ID?
> 
> I will introduce new bug, when approach from this bug will be accepted. Now
> there is no point for this.
> 
> > ERROR: Source/WebKit2/UIProcess/API/efl/ewk_context.h:369:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> 
> This is caused by space aligment in ewk_context.h (that is why I used only 4
> spaces there in initial patch). As far as I know checking style in *.h files
> should be disabled so probably those messages can be ignored. 
> 

Hmm, we can consider to add exception for check-webkit-style.
But I am not sure which one is better for us.

gyuyoung, what do you think about it?

> Best regards,
> Lukasz Bialek

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150304/23a23ba1/attachment-0002.html>