[Webkit-unassigned] [Bug 142079] REGRESSION(r177075): WebProcess crashes when entering accelerating compositing mode before the WebView is realized

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142079

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 247504
  --> https://bugs.webkit.org/attachment.cgi?id=247504
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247504&action=review

Thanks for the review, I'll submit a new patch.

>> Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:86
>> +        m_context = GLContext::createContextForWindow(m_layerTreeContext.contextID, GLContext::sharingContext());
> 
> GLContext::createContextForWindow() can still return null. But you don't want to call that every time you call LayerTreeHostGtk::makeContextCurrent().

I'm not sure I get what you mean, I need to check if m_context is nullptr or not, that's right. But why not calling this everytime LayerTreeHostGtk::makeContextCurrent() is called? It's only called when the context is nullptr. I noticed that glContext() was always used to make the context current, that's why I tried to simplify the caller with this method, that it should do the same than previous code (it doesn't because I made some mistakes, though)

>> Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:90
>> +    return true;
> 
> Here you should return the return value of GLContext::makeContextCurrent().

Right.

> Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:-123
> -    context->makeContextCurrent();

So, here for example we are not checking the return value of makeContextCurrent(), I guess we should, there's a comment saying that the creation fo the texture mapper needs an active context, and we are creating the texture mapper after this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150302/b38b6b39/attachment-0002.html>