[Webkit-unassigned] [Bug 142079] REGRESSION(r177075): WebProcess crashes when entering accelerating compositing mode before the WebView is realized

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142079

--- Comment #3 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 247504
  --> https://bugs.webkit.org/attachment.cgi?id=247504
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247504&action=review

> Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:86
> +        m_context = GLContext::createContextForWindow(m_layerTreeContext.contextID, GLContext::sharingContext());

GLContext::createContextForWindow() can still return null. But you don't want to call that every time you call LayerTreeHostGtk::makeContextCurrent().

> Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:90
> +    m_context->makeContextCurrent();
> +    return true;

Here you should return the return value of GLContext::makeContextCurrent().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150302/c7e76d96/attachment-0002.html>