[Webkit-unassigned] [Bug 146356] Test existence of controls on MediaSession

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146356

Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255682|review?                     |review+
              Flags|                            |

--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 255682
  --> https://bugs.webkit.org/attachment.cgi?id=255682
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255682&action=review

> LayoutTests/ChangeLog:9
> +        * media/session/controls-existence-expected.txt: Added.
> +        * media/session/controls-existence.html: Added.

You need to mark the new test as Skipped in LayoutTests/platform/mac/TestExpectations.

> LayoutTests/media/session/controls-existence-expected.txt:6
> +EXPECTED (session.controls != 'null') OK
> +EXPECTED (session.controls == 'null') OK
> +EXPECTED (session.controls == 'null') OK
> +EXPECTED (session.controls == 'null') OK

Nit: It can be helpful to have more context about what is being tested in the results, so it would be helpful to log the session type. For example:

    run("session = new MediaSession('content')");
    testExpected("session.controls", null, '!=');

or maybe

    testExpected("new MediaSession('content').controls", null, '!=');

etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150627/f1f1ffec/attachment-0001.html>