<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Test existence of controls on MediaSession"
href="https://bugs.webkit.org/show_bug.cgi?id=146356">bug 146356</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #255682 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Test existence of controls on MediaSession"
href="https://bugs.webkit.org/show_bug.cgi?id=146356#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Test existence of controls on MediaSession"
href="https://bugs.webkit.org/show_bug.cgi?id=146356">bug 146356</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255682&action=diff" name="attach_255682" title="Patch">attachment 255682</a> <a href="attachment.cgi?id=255682&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255682&action=review">https://bugs.webkit.org/attachment.cgi?id=255682&action=review</a>
<span class="quote">> LayoutTests/ChangeLog:9
> + * media/session/controls-existence-expected.txt: Added.
> + * media/session/controls-existence.html: Added.</span >
You need to mark the new test as Skipped in LayoutTests/platform/mac/TestExpectations.
<span class="quote">> LayoutTests/media/session/controls-existence-expected.txt:6
> +EXPECTED (session.controls != 'null') OK
> +EXPECTED (session.controls == 'null') OK
> +EXPECTED (session.controls == 'null') OK
> +EXPECTED (session.controls == 'null') OK</span >
Nit: It can be helpful to have more context about what is being tested in the results, so it would be helpful to log the session type. For example:
run("session = new MediaSession('content')");
testExpected("session.controls", null, '!=');
or maybe
testExpected("new MediaSession('content').controls", null, '!=');
etc.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>