[Webkit-unassigned] [Bug 146350] Add support for image previews

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 26 14:04:09 PDT 2015


Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
 Attachment #255661|review?                     |review+
              Flags|                            |

--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 255661
  --> https://bugs.webkit.org/attachment.cgi?id=255661

View in context: https://bugs.webkit.org/attachment.cgi?id=255661&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3139
> +        NSURL *targetURL = [NSURL URLWithString:_positionInformation.url];

This probably should use _web_URLWithWTFString?

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2142
> +                            if (RefPtr<ShareableBitmap> sharedBitmap = ShareableBitmap::createShareable(IntSize(image->size()), ShareableBitmap::SupportsAlpha)) {

Wonder if we should have a cap too (screen size?).

Also should consider what should happen with animated images.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150626/ad096481/attachment.html>

More information about the webkit-unassigned mailing list