<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for image previews"
href="https://bugs.webkit.org/show_bug.cgi?id=146350">bug 146350</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #255661 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for image previews"
href="https://bugs.webkit.org/show_bug.cgi?id=146350#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for image previews"
href="https://bugs.webkit.org/show_bug.cgi?id=146350">bug 146350</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255661&action=diff" name="attach_255661" title="Patch">attachment 255661</a> <a href="attachment.cgi?id=255661&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255661&action=review">https://bugs.webkit.org/attachment.cgi?id=255661&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3139
> + NSURL *targetURL = [NSURL URLWithString:_positionInformation.url];</span >
This probably should use _web_URLWithWTFString?
<span class="quote">> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2142
> + if (RefPtr<ShareableBitmap> sharedBitmap = ShareableBitmap::createShareable(IntSize(image->size()), ShareableBitmap::SupportsAlpha)) {</span >
Wonder if we should have a cap too (screen size?).
Also should consider what should happen with animated images.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>