[Webkit-unassigned] [Bug 146354] Make NetworkCache::traverse faster

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 26 12:05:46 PDT 2015


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
 Attachment #255655|review?                     |review+
              Flags|                            |

--- Comment #3 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 255655
  --> https://bugs.webkit.org/attachment.cgi?id=255655

View in context: https://bugs.webkit.org/attachment.cgi?id=255655&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:107
> +void IOChannel::write(size_t offset, const Data& data, WorkQueue* queue, const std::function<void (int error)>& completionHandler)

I don't think this should be a const& since that's an extra copy.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:704
> +    std::unique_ptr<TraverseOperation> traverseOperationPtr(new TraverseOperation { flags, WTF::move(traverseHandler) });

auto + std::make_unique?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150626/c0d5e6b5/attachment.html>

More information about the webkit-unassigned mailing list