<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:andersca@apple.com" title="Anders Carlsson <andersca@apple.com>"> <span class="fn">Anders Carlsson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Make NetworkCache::traverse faster"
href="https://bugs.webkit.org/show_bug.cgi?id=146354">bug 146354</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #255655 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Make NetworkCache::traverse faster"
href="https://bugs.webkit.org/show_bug.cgi?id=146354#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Make NetworkCache::traverse faster"
href="https://bugs.webkit.org/show_bug.cgi?id=146354">bug 146354</a>
from <span class="vcard"><a class="email" href="mailto:andersca@apple.com" title="Anders Carlsson <andersca@apple.com>"> <span class="fn">Anders Carlsson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255655&action=diff" name="attach_255655" title="patch">attachment 255655</a> <a href="attachment.cgi?id=255655&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255655&action=review">https://bugs.webkit.org/attachment.cgi?id=255655&action=review</a>
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:107
> +void IOChannel::write(size_t offset, const Data& data, WorkQueue* queue, const std::function<void (int error)>& completionHandler)</span >
I don't think this should be a const& since that's an extra copy.
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:704
> + std::unique_ptr<TraverseOperation> traverseOperationPtr(new TraverseOperation { flags, WTF::move(traverseHandler) });</span >
auto + std::make_unique?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>