[Webkit-unassigned] [Bug 146282] MediaSession: propagate MediaSessionMetadata to WebPageProxy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146282

--- Comment #9 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #6)
> Comment on attachment 255491 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255491&action=review
> 
> > Source/WebCore/Modules/mediasession/MediaSession.cpp:104
> > +    m_document.page()->chrome().client().mediaSessionMetadataDidChange(m_metadata);
> 
> What guarantees that page() is not null here? We should check it for null
> unless there is an ironclad guarantee it can’t be.

Added the null check.

> 
> > Source/WebCore/page/ChromeClient.h:50
> > +#if ENABLE(MEDIA_SESSION)
> > +#include "MediaSessionMetadata.h"
> > +#endif
> 
> We should not include this header. We should be able to just forward-declare
> MediaSessionMetadata to compile this header.

Changed. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150624/4558f03c/attachment.html>