<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - MediaSession: propagate MediaSessionMetadata to WebPageProxy"
href="https://bugs.webkit.org/show_bug.cgi?id=146282#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - MediaSession: propagate MediaSessionMetadata to WebPageProxy"
href="https://bugs.webkit.org/show_bug.cgi?id=146282">bug 146282</a>
from <span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=146282#c6">comment #6</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=255491&action=diff" name="attach_255491" title="Patch">attachment 255491</a> <a href="attachment.cgi?id=255491&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=255491&action=review">https://bugs.webkit.org/attachment.cgi?id=255491&action=review</a>
>
> > Source/WebCore/Modules/mediasession/MediaSession.cpp:104
> > + m_document.page()->chrome().client().mediaSessionMetadataDidChange(m_metadata);
>
> What guarantees that page() is not null here? We should check it for null
> unless there is an ironclad guarantee it can’t be.</span >
Added the null check.
<span class="quote">>
> > Source/WebCore/page/ChromeClient.h:50
> > +#if ENABLE(MEDIA_SESSION)
> > +#include "MediaSessionMetadata.h"
> > +#endif
>
> We should not include this header. We should be able to just forward-declare
> MediaSessionMetadata to compile this header.</span >
Changed. Thanks!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>