[Webkit-unassigned] [Bug 146282] MediaSession: propagate MediaSessionMetadata to WebPageProxy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146282

--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 255491
  --> https://bugs.webkit.org/attachment.cgi?id=255491
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255491&action=review

> Source/WebCore/page/ChromeClient.h:49
> +#include "MediaSessionMetadata.h"

Please forward-declare instead of including this header (it seems like you can, right?). ChromeClient.h is included in a billion places and this will just make the build slower.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:5775
> +{

I assume you're going to put something here in a near-future patch?

> Source/WebKit2/UIProcess/WebPageProxy.h:123
> +#if ENABLE(MEDIA_SESSION)
> +#include <WebCore/MediaSessionMetadata.h>

Ditto here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150624/c2d707d7/attachment.html>