<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - MediaSession: propagate MediaSessionMetadata to WebPageProxy"
href="https://bugs.webkit.org/show_bug.cgi?id=146282#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - MediaSession: propagate MediaSessionMetadata to WebPageProxy"
href="https://bugs.webkit.org/show_bug.cgi?id=146282">bug 146282</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255491&action=diff" name="attach_255491" title="Patch">attachment 255491</a> <a href="attachment.cgi?id=255491&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255491&action=review">https://bugs.webkit.org/attachment.cgi?id=255491&action=review</a>
<span class="quote">> Source/WebCore/page/ChromeClient.h:49
> +#include "MediaSessionMetadata.h"</span >
Please forward-declare instead of including this header (it seems like you can, right?). ChromeClient.h is included in a billion places and this will just make the build slower.
<span class="quote">> Source/WebKit2/UIProcess/WebPageProxy.cpp:5775
> +{</span >
I assume you're going to put something here in a near-future patch?
<span class="quote">> Source/WebKit2/UIProcess/WebPageProxy.h:123
> +#if ENABLE(MEDIA_SESSION)
> +#include <WebCore/MediaSessionMetadata.h></span >
Ditto here.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>