[Webkit-unassigned] [Bug 146149] [GTK] Add initial WebKitWebsiteDataManager API for process configuration options

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146149

--- Comment #9 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 255402
  --> https://bugs.webkit.org/attachment.cgi?id=255402
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255402&action=review

The API looks fine to me.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:382
> +            _("The WebKitWebsiteDataManager associated to this context"),

English nit: associated to -> associated with

PS: Sorry about English.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:43
> + * a default value will be used automatically for the confoguration options

Nit: confoguration -> configuration

> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:355
> + * Returns: the base directory for Website data, or %NULL if

Website is capitalized here, but not earlier.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150624/b4c6a06d/attachment.html>