<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add initial WebKitWebsiteDataManager API for process configuration options"
href="https://bugs.webkit.org/show_bug.cgi?id=146149#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add initial WebKitWebsiteDataManager API for process configuration options"
href="https://bugs.webkit.org/show_bug.cgi?id=146149">bug 146149</a>
from <span class="vcard"><a class="email" href="mailto:mrobinson@webkit.org" title="Martin Robinson <mrobinson@webkit.org>"> <span class="fn">Martin Robinson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255402&action=diff" name="attach_255402" title="Updated patch">attachment 255402</a> <a href="attachment.cgi?id=255402&action=edit" title="Updated patch">[details]</a></span>
Updated patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255402&action=review">https://bugs.webkit.org/attachment.cgi?id=255402&action=review</a>
The API looks fine to me.
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:382
> + _("The WebKitWebsiteDataManager associated to this context"),</span >
English nit: associated to -> associated with
PS: Sorry about English.
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:43
> + * a default value will be used automatically for the confoguration options</span >
Nit: confoguration -> configuration
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:355
> + * Returns: the base directory for Website data, or %NULL if</span >
Website is capitalized here, but not earlier.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>