[Webkit-unassigned] [Bug 146242] WinLauncher fails to download files.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146242

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255420|review?                     |review-
              Flags|                            |

--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 255420
  --> https://bugs.webkit.org/attachment.cgi?id=255420
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255420&action=review

Hooray!  Downloading things from WinLauncher!  A few memory management issues, but otherwise this is great!

> Tools/WinLauncher/WebDownloadDelegate.cpp:32
> +    : m_refCount(1)

I don't think this is correct.  Something that adopts this should call AddRef then Release when it is done with it, which should delete it if that was the only reference to it.

> Tools/WinLauncher/WinMain.cpp:139
> +    hr = gWinLauncher->setDownloadDelegate(new WebDownloadDelegate());

This is a memory leak.  Use the same pattern as gWinLauncher if this is global, otherwise use some kind of smart pointer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150623/a4331d81/attachment.html>