<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - WinLauncher fails to download files."
href="https://bugs.webkit.org/show_bug.cgi?id=146242">bug 146242</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #255420 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WinLauncher fails to download files."
href="https://bugs.webkit.org/show_bug.cgi?id=146242#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WinLauncher fails to download files."
href="https://bugs.webkit.org/show_bug.cgi?id=146242">bug 146242</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255420&action=diff" name="attach_255420" title="Patch">attachment 255420</a> <a href="attachment.cgi?id=255420&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255420&action=review">https://bugs.webkit.org/attachment.cgi?id=255420&action=review</a>
Hooray! Downloading things from WinLauncher! A few memory management issues, but otherwise this is great!
<span class="quote">> Tools/WinLauncher/WebDownloadDelegate.cpp:32
> + : m_refCount(1)</span >
I don't think this is correct. Something that adopts this should call AddRef then Release when it is done with it, which should delete it if that was the only reference to it.
<span class="quote">> Tools/WinLauncher/WinMain.cpp:139
> + hr = gWinLauncher->setDownloadDelegate(new WebDownloadDelegate());</span >
This is a memory leak. Use the same pattern as gWinLauncher if this is global, otherwise use some kind of smart pointer.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>