[Webkit-unassigned] [Bug 146175] Get rid of factory json files in benchmark_runner

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 22 17:39:47 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=146175

--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 255366
  --> https://bugs.webkit.org/attachment.cgi?id=255366
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255366&action=review

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:32
> +    def get(cls, platform, browser_name):

I don't think we should rename this to `get`.
`create` is more semantically correct name.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150623/edaa4afb/attachment.html>


More information about the webkit-unassigned mailing list