<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Get rid of factory json files in benchmark_runner"
href="https://bugs.webkit.org/show_bug.cgi?id=146175#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Get rid of factory json files in benchmark_runner"
href="https://bugs.webkit.org/show_bug.cgi?id=146175">bug 146175</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255366&action=diff" name="attach_255366" title="Patch">attachment 255366</a> <a href="attachment.cgi?id=255366&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255366&action=review">https://bugs.webkit.org/attachment.cgi?id=255366&action=review</a>
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:32
> + def get(cls, platform, browser_name):</span >
I don't think we should rename this to `get`.
`create` is more semantically correct name.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>