[Webkit-unassigned] [Bug 146175] Get rid of factory json files in benchmark_runner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146175

--- Comment #7 from dewei_zhu at apple.com ---
Comment on attachment 255286
  --> https://bugs.webkit.org/attachment.cgi?id=255286
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255286&action=review

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py:23
> +        BenchmarkBuilderFactory.add_product([benchmark_builder_class.builder_name], benchmark_builder_class)

Should I add a add_benchmark_builder method instead?

> Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:23
> +        HTTPServerDriverFactory.add_product([http_server_driver_class.name], http_server_driver_class)

Should I change here as well?

>> Tools/Scripts/webkitpy/benchmark_runner/utils.py:21
>> +    return False
> 
> This should be re-rewritten as:
> return inspect.isclass(child) and parent_name in [cls.__name__ for cls in inspect.getmro(child)]

Nice!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150622/41080a47/attachment.html>