<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Get rid of factory json files in benchmark_runner"
href="https://bugs.webkit.org/show_bug.cgi?id=146175#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Get rid of factory json files in benchmark_runner"
href="https://bugs.webkit.org/show_bug.cgi?id=146175">bug 146175</a>
from <span class="vcard"><a class="email" href="mailto:dewei_zhu@apple.com" title="dewei_zhu@apple.com">dewei_zhu@apple.com</a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255286&action=diff" name="attach_255286" title="Patch">attachment 255286</a> <a href="attachment.cgi?id=255286&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255286&action=review">https://bugs.webkit.org/attachment.cgi?id=255286&action=review</a>
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py:23
> + BenchmarkBuilderFactory.add_product([benchmark_builder_class.builder_name], benchmark_builder_class)</span >
Should I add a add_benchmark_builder method instead?
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:23
> + HTTPServerDriverFactory.add_product([http_server_driver_class.name], http_server_driver_class)</span >
Should I change here as well?
<span class="quote">>> Tools/Scripts/webkitpy/benchmark_runner/utils.py:21
>> + return False
>
> This should be re-rewritten as:
> return inspect.isclass(child) and parent_name in [cls.__name__ for cls in inspect.getmro(child)]</span >
Nice!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>