[Webkit-unassigned] [Bug 146102] Do not store configuration parameters twice in WebProcessPool

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146102

--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 255100
  --> https://bugs.webkit.org/attachment.cgi?id=255100
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255100&action=review

> Source/WebKit2/UIProcess/WebProcessPool.cpp:357
>  void WebProcessPool::setUsesNetworkProcess(bool usesNetworkProcess)
>  {
>  #if ENABLE(NETWORK_PROCESS)
> -    m_usesNetworkProcess = usesNetworkProcess;
> +    m_configuration->setUseNetworkProcess(usesNetworkProcess);

This is a subtle change in behavior.  Before, the configuration was unchanged if someone called WebProcessPool::setUsesNetworkProcess() (via WKContextSetUsesNetworkProcess(...)), but now it will be mutated.  I'm not sure if this is a big deal in practice.  The same is true with WebProcessPool::setMaximumNumberOfProcesses() and WebProcessPool::setProcessModel().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150619/27edc360/attachment.html>