<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Do not store configuration parameters twice in WebProcessPool"
href="https://bugs.webkit.org/show_bug.cgi?id=146102#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Do not store configuration parameters twice in WebProcessPool"
href="https://bugs.webkit.org/show_bug.cgi?id=146102">bug 146102</a>
from <span class="vcard"><a class="email" href="mailto:sam@webkit.org" title="Sam Weinig <sam@webkit.org>"> <span class="fn">Sam Weinig</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255100&action=diff" name="attach_255100" title="Patch">attachment 255100</a> <a href="attachment.cgi?id=255100&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255100&action=review">https://bugs.webkit.org/attachment.cgi?id=255100&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/WebProcessPool.cpp:357
> void WebProcessPool::setUsesNetworkProcess(bool usesNetworkProcess)
> {
> #if ENABLE(NETWORK_PROCESS)
> - m_usesNetworkProcess = usesNetworkProcess;
> + m_configuration->setUseNetworkProcess(usesNetworkProcess);</span >
This is a subtle change in behavior. Before, the configuration was unchanged if someone called WebProcessPool::setUsesNetworkProcess() (via WKContextSetUsesNetworkProcess(...)), but now it will be mutated. I'm not sure if this is a big deal in practice. The same is true with WebProcessPool::setMaximumNumberOfProcesses() and WebProcessPool::setProcessModel().</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>