[Webkit-unassigned] [Bug 146125] Extend run-benchmark script capability to supoort mobile device

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146125

--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 255159
  --> https://bugs.webkit.org/attachment.cgi?id=255159
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255159&action=review

> Tools/ChangeLog:8
> +        Extend capability of run-benchmark to support mobile device

You need a period after the sentence.

> Tools/ChangeLog:11
> +        Correct typo.
> +        * Scripts/run-benchmark:

You need a blank line between the line line of the description and the list of files.

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:9
> -    def prepareEnv(self):
> +    def prepareEnv(self, deviceID=None):

We don't need default arguments in these functions because we always call it with deviceID.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150619/53b05213/attachment.html>