<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Extend run-benchmark script capability to supoort mobile device"
href="https://bugs.webkit.org/show_bug.cgi?id=146125#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Extend run-benchmark script capability to supoort mobile device"
href="https://bugs.webkit.org/show_bug.cgi?id=146125">bug 146125</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255159&action=diff" name="attach_255159" title="Patch">attachment 255159</a> <a href="attachment.cgi?id=255159&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255159&action=review">https://bugs.webkit.org/attachment.cgi?id=255159&action=review</a>
<span class="quote">> Tools/ChangeLog:8
> + Extend capability of run-benchmark to support mobile device</span >
You need a period after the sentence.
<span class="quote">> Tools/ChangeLog:11
> + Correct typo.
> + * Scripts/run-benchmark:</span >
You need a blank line between the line line of the description and the list of files.
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:9
> - def prepareEnv(self):
> + def prepareEnv(self, deviceID=None):</span >
We don't need default arguments in these functions because we always call it with deviceID.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>