[Webkit-unassigned] [Bug 146125] Extend run-benchmark script capability to supoort mobile device

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146125

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255143|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 255143
  --> https://bugs.webkit.org/attachment.cgi?id=255143
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255143&action=review

> Tools/ChangeLog:7
> +

You should explain what kind of code changes you're making here.
See other change log entires.

> Tools/Scripts/run-benchmark:14
>  _log.addHandler(ch)

This logging code should also be moved into some helper function in run_benchmark.py

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:29
> +        _log.info('Initializing benchmark runner')

This logging is probably not useful. Remove it?

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:9
> -    def prepareEnv(self):
> +    def prepareEnv(self, udid=None):

Why don't we stick with the same "deviceID"?

> Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py:13
> +# _log.setLevel(logging.INFO)

What's going on with these commented out code?
r- because of this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150619/e533c82b/attachment-0001.html>