<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Extend run-benchmark script capability to supoort mobile device"
href="https://bugs.webkit.org/show_bug.cgi?id=146125">bug 146125</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #255143 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Extend run-benchmark script capability to supoort mobile device"
href="https://bugs.webkit.org/show_bug.cgi?id=146125#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Extend run-benchmark script capability to supoort mobile device"
href="https://bugs.webkit.org/show_bug.cgi?id=146125">bug 146125</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255143&action=diff" name="attach_255143" title="Patch">attachment 255143</a> <a href="attachment.cgi?id=255143&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255143&action=review">https://bugs.webkit.org/attachment.cgi?id=255143&action=review</a>
<span class="quote">> Tools/ChangeLog:7
> +</span >
You should explain what kind of code changes you're making here.
See other change log entires.
<span class="quote">> Tools/Scripts/run-benchmark:14
> _log.addHandler(ch)</span >
This logging code should also be moved into some helper function in run_benchmark.py
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:29
> + _log.info('Initializing benchmark runner')</span >
This logging is probably not useful. Remove it?
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:9
> - def prepareEnv(self):
> + def prepareEnv(self, udid=None):</span >
Why don't we stick with the same "deviceID"?
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py:13
> +# _log.setLevel(logging.INFO)</span >
What's going on with these commented out code?
r- because of this.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>