[Webkit-unassigned] [Bug 146028] MediaSession: handle MediaEventTrackNext and MediaEventTrackPrevious events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146028

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254970|review?                     |review+
              Flags|                            |

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 254970
  --> https://bugs.webkit.org/attachment.cgi?id=254970
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254970&action=review

> Source/WebCore/Modules/mediasession/MediaSessionManager.cpp:67
> +        if (session->currentState() == MediaSession::State::Active && session->kind() == "content")

Generally it’s not good for an enum value to be a string literal at each call site like this. It’s easy to have a typo and the compiler won’t catch it. I suggest making constants for these special kind values somewhere, so that we get a compile time error if we spell it wrong somewhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150617/3ab60324/attachment.html>