<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - MediaSession: handle MediaEventTrackNext and MediaEventTrackPrevious events"
href="https://bugs.webkit.org/show_bug.cgi?id=146028">bug 146028</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #254970 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - MediaSession: handle MediaEventTrackNext and MediaEventTrackPrevious events"
href="https://bugs.webkit.org/show_bug.cgi?id=146028#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - MediaSession: handle MediaEventTrackNext and MediaEventTrackPrevious events"
href="https://bugs.webkit.org/show_bug.cgi?id=146028">bug 146028</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254970&action=diff" name="attach_254970" title="Patch">attachment 254970</a> <a href="attachment.cgi?id=254970&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254970&action=review">https://bugs.webkit.org/attachment.cgi?id=254970&action=review</a>
<span class="quote">> Source/WebCore/Modules/mediasession/MediaSessionManager.cpp:67
> + if (session->currentState() == MediaSession::State::Active && session->kind() == "content")</span >
Generally it’s not good for an enum value to be a string literal at each call site like this. It’s easy to have a typo and the compiler won’t catch it. I suggest making constants for these special kind values somewhere, so that we get a compile time error if we spell it wrong somewhere.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>