[Webkit-unassigned] [Bug 145858] Move cursor to corner and fix safari window size before running benchmark

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 11 16:30:47 PDT 2015


--- Comment #12 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 254764
  --> https://bugs.webkit.org/attachment.cgi?id=254764

View in context: https://bugs.webkit.org/attachment.cgi?id=254764&action=review

> Tools/ChangeLog:6
> +        Reviewed by Ryosuke Niwa

You shouldn't fill this up until you get r+ because it implies I've already given you r+, which I haven't.

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:25
> -        self.launchProcess(buildDir=browserBuildPath, appName='Google Chrome Canary.app', url=url, args=['--args', '--homepage', url])
> +        self.launchProcess(buildDir=browserBuildPath, appName='Google Chrome Canary.app', url=url, args=['--args', '--homepage', url, '--window-size={width},{height}'.format(width=self.screenSize()[0], height=self.screenSize()[1])])

Can we instead make self.screenSize() return a dictionary with width/height as keys?

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:24
> +        self.moveCursor(0, 0)

Instead of duplicating calls to closeBrowsers and moveCursor here, why don't we just call super(OSXSafariDriver, self).prepareEnv() ?

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:58
> +            # resolution = re.split('\s+', NSUserDefaults.standardUserDefaults().persistentDomainForName_('com.apple.Safari')['NSWindow Frame BrowserWindowFrame'].strip())[4:]
> +            resolution = re.split('\s+', subprocess.check_output(['/usr/bin/defaults', 'read', 'com.apple.Safari', 'NSWindow Frame BrowserWindowFrame']).strip())[4:]

Can't we just use self.screenSize here instead of user defaults craziness?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150611/3661cb8c/attachment-0001.html>

More information about the webkit-unassigned mailing list