<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Move cursor to corner and fix safari window size before running benchmark"
href="https://bugs.webkit.org/show_bug.cgi?id=145858#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Move cursor to corner and fix safari window size before running benchmark"
href="https://bugs.webkit.org/show_bug.cgi?id=145858">bug 145858</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254764&action=diff" name="attach_254764" title="Patch">attachment 254764</a> <a href="attachment.cgi?id=254764&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254764&action=review">https://bugs.webkit.org/attachment.cgi?id=254764&action=review</a>
<span class="quote">> Tools/ChangeLog:6
> + Reviewed by Ryosuke Niwa</span >
You shouldn't fill this up until you get r+ because it implies I've already given you r+, which I haven't.
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:25
> - self.launchProcess(buildDir=browserBuildPath, appName='Google Chrome Canary.app', url=url, args=['--args', '--homepage', url])
> + self.launchProcess(buildDir=browserBuildPath, appName='Google Chrome Canary.app', url=url, args=['--args', '--homepage', url, '--window-size={width},{height}'.format(width=self.screenSize()[0], height=self.screenSize()[1])])</span >
Can we instead make self.screenSize() return a dictionary with width/height as keys?
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:24
> + self.moveCursor(0, 0)</span >
Instead of duplicating calls to closeBrowsers and moveCursor here, why don't we just call super(OSXSafariDriver, self).prepareEnv() ?
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:58
> + # resolution = re.split('\s+', NSUserDefaults.standardUserDefaults().persistentDomainForName_('com.apple.Safari')['NSWindow Frame BrowserWindowFrame'].strip())[4:]
> + resolution = re.split('\s+', subprocess.check_output(['/usr/bin/defaults', 'read', 'com.apple.Safari', 'NSWindow Frame BrowserWindowFrame']).strip())[4:]</span >
Can't we just use self.screenSize here instead of user defaults craziness?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>