[Webkit-unassigned] [Bug 145858] Move cursor to corner and fix safari window size before running benchmark

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145858

--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 254760
  --> https://bugs.webkit.org/attachment.cgi?id=254760
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254760&action=review

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:60
> +    def getScreenSize(cls):

In WebKit, we use "get" prefix only when we have an out argument.
See http://www.webkit.org/coding/coding-style.html#names-out-argument

So this function should be "screenSize" instead.

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:18
> +        self.launchProcess(buildDir=browserBuildPath, appName='Google Chrome.app', url=url, args=['--args', '--homepage', url, '--window-size={0},{1}'.format(self.getScreenSize()[0], self.getScreenSize()[1])])

Please use named format e.g. '{width}{height}'.format(width=~, height=~).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150611/6bb0ccd8/attachment.html>