<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Move cursor to corner and fix safari window size before running benchmark"
href="https://bugs.webkit.org/show_bug.cgi?id=145858#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Move cursor to corner and fix safari window size before running benchmark"
href="https://bugs.webkit.org/show_bug.cgi?id=145858">bug 145858</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254760&action=diff" name="attach_254760" title="Patch">attachment 254760</a> <a href="attachment.cgi?id=254760&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254760&action=review">https://bugs.webkit.org/attachment.cgi?id=254760&action=review</a>
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:60
> + def getScreenSize(cls):</span >
In WebKit, we use "get" prefix only when we have an out argument.
See <a href="http://www.webkit.org/coding/coding-style.html#names-out-argument">http://www.webkit.org/coding/coding-style.html#names-out-argument</a>
So this function should be "screenSize" instead.
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:18
> + self.launchProcess(buildDir=browserBuildPath, appName='Google Chrome.app', url=url, args=['--args', '--homepage', url, '--window-size={0},{1}'.format(self.getScreenSize()[0], self.getScreenSize()[1])])</span >
Please use named format e.g. '{width}{height}'.format(width=~, height=~).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>