[Webkit-unassigned] [Bug 145457] [EFL] Jpeg image export implementation for Canvas.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145457

--- Comment #8 from KwangHyuk <hyuki.kim at samsung.com> ---
(In reply to comment #7)
> Comment on attachment 254579 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254579&action=review
> 
> LGTM except for a trivial comment.
> 
> > Source/WebCore/ChangeLog:10
> > +        No new tests, LayoutTests/fast/canvas/toDataURL-supportedTypes.html can be reused.
> 
> Unnecessary "LayoutTests/" in test path.
> 

Ok, thanks.

> > Source/WebCore/platform/graphics/efl/ImageBufferEfl.cpp:75
> > +    return "data:" + mimeType + ";base64," + base64Data;
> 
> Isn't StringBuilder more efficient ?
> 
> https://trac.webkit.org/wiki/EfficientStrings

But, this is the general implementation for every ports like ImageBufferGtk, ImageBufferCairo as well as ImageBufferCG.
Therefore, may be, keeping of this implementation looks fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150610/26dcd89f/attachment.html>